SRVOCF-946: Add Husky pre-commit hook with lint, type-check, and Go checks#45
Open
Cragsmann wants to merge 1 commit into
Open
SRVOCF-946: Add Husky pre-commit hook with lint, type-check, and Go checks#45Cragsmann wants to merge 1 commit into
Cragsmann wants to merge 1 commit into
Conversation
twoGiants
approved these changes
Jun 18, 2026
twoGiants
left a comment
twoGiants
left a comment
Collaborator
There was a problem hiding this comment.
Looks good! Thank you for this. 👍
twoGiants
requested changes
Jun 18, 2026
twoGiants
left a comment
twoGiants
left a comment
Collaborator
There was a problem hiding this comment.
One thing. Can you use our commit message standard?
Please use the commit message slash command or the commit message guide to craft a brief commit message using conventional commits spec.
What do you think about adding a commit lint to the pre-commit hook too in a follow up PR?
Collaborator
|
plz update ./docs/claude-progress.txt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
yarn lint:fix,tsc --noEmit, andgo vet/gofmton backend/type-checkandpreparescripts to package.jsonskipLibCheck: trueto tsconfig.json (prevents false positives from third-party type declarations)yarn installvia thepreparescriptTest plan
yarn lint:fixpassesyarn type-checkpasses